-
Notifications
You must be signed in to change notification settings - Fork 2
v1: MatplotlibChart interactive with toolbar #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed 'init' to 'build' in MatplotlibChart for clarity. Changed pan and zoom toolbar icons in tests to use OPEN_WITH and SEARCH for better representation.
Added MatplotlibChartMessageEvent and MatplotlibChartToolbarButtonsUpdateEvent to the public API in __init__.py. Also replaced async canvas capture methods with their synchronous counterparts in MatplotlibChart for image handling.
Refactored src/flet_charts/matplotlib_chart.py for improved readability, async focus handling, and event argument types. Updated test files to use consistent formatting, removed unused imports, and replaced deprecated FilePicker API usage. Enhanced code clarity and maintainability across chart and test modules.
Introduces MatplotlibChartWithToolbar for integrated chart and toolbar controls. Updates __init__.py to export the new class, refactors tests/mpl_v2_basic.py to use MatplotlibChartWithToolbar, and adds debug output and minor improvements to MatplotlibChart.
Added 'isolated=True' to chart controls for better encapsulation. Replaced print statements with logger.debug for improved logging. Refactored test files to use MatplotlibChartWithToolbar, simplifying toolbar and event handling logic, and added a new 3D chart test.
Moved the matplotlib backend configuration to the main library file (matplotlib_chart.py) and removed redundant backend setting from all test files. This centralizes backend setup and simplifies test scripts.
Specifies the figure size in the 3D plot test and removes the 'expand=True' argument from MatplotlibChartWithToolbar for consistency and improved layout control.
Deploying flet-charts-docs with
|
| Latest commit: |
122c6bd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f2e098fd.flet-charts-docs.pages.dev |
| Branch Preview URL: | https://feodor-v1-matplotlib-interac.flet-charts-docs.pages.dev |
Refactored the download method to instantiate FilePicker inline instead of assigning it to a variable, simplifying the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.